fix: change tab block-size to min-block-size to allow height to grow - #1219
Merged
Conversation
also change to correct custom property to ensure minimum target size
maxelkins
temporarily deployed
to
previews/1219/merge
June 17, 2025 15:40 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
maxelkins
changed the title
block-size to min-block-size to allow height to growblock-size to min-block-size to allow height to grow
maxelkins
temporarily deployed
to
previews/1219/merge
June 17, 2025 16:00 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
danhalson
reviewed
Jun 17, 2025
maxelkins
temporarily deployed
to
previews/1219/merge
June 17, 2025 16:30 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Author
|
@danhalson fixed the changelog issue, there was another unreleased change that was there too |
maxelkins
temporarily deployed
to
previews/1219/merge
June 18, 2025 09:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
maxelkins
temporarily deployed
to
previews/1219/merge
June 18, 2025 12:44 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
…ock-size - Switched from manipulating `block-size` to `display: none` for more robust and explicit hiding of the visual output panel and its corresponding tab. - Ensures elements are truly removed from the layout, preventing subtle rendering issues and improving reliability for Cypress visibility assertions
maxelkins
temporarily deployed
to
previews/1219/merge
June 18, 2025 15:08 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
maxelkins
temporarily deployed
to
previews/1219/merge
June 18, 2025 15:14 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
maxelkins
temporarily deployed
to
previews/1219/merge
June 18, 2025 15:38 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
maxelkins
enabled auto-merge (squash)
June 18, 2025 15:39
Merged
jamiebenstead
added a commit
that referenced
this pull request
Jul 22, 2025
## [0.30.2] - 2025-07-22 ### Fixed - Styling issue preventing scrolling in the sidebar (#1216) - Styling issue on status bar on mobile (#1217) - Change tab `block-size` to `min-block-size` to allow for height increase when text wraps (#1219) - Changed `SkulptRunner.jsx` implementation of hiding elements to use `display: none` rather than `block-size: 0` (#1219) - Enabled `hyphens: auto` globally (with exceptions) to prevent overflow with longer words (#1215) - Removed fixed size from `ProjectBar` to prevent overflow when text wraps (#1221) - Added missing translation strings (#1222) - Changed `colour_raw` to now correctly return a 4-tuple (R, G, B, Clear) in simulation ### Changed - Improved status bar styling (#1221) - Added horizontal scrollbar to editor (#1228) - Add theme for scrollbars (#1233)
jamiebenstead
added a commit
that referenced
this pull request
Jul 28, 2025
## [0.30.2] - 2025-07-22 ### Fixed - Styling issue preventing scrolling in the sidebar (#1216) - Styling issue on status bar on mobile (#1217) - Change tab `block-size` to `min-block-size` to allow for height increase when text wraps (#1219) - Changed `SkulptRunner.jsx` implementation of hiding elements to use `display: none` rather than `block-size: 0` (#1219) - Enabled `hyphens: auto` globally (with exceptions) to prevent overflow with longer words (#1215) - Removed fixed size from `ProjectBar` to prevent overflow when text wraps (#1221) - Added missing translation strings (#1222) - Changed `colour_raw` to now correctly return a 4-tuple (R, G, B, Clear) in simulation ### Changed - Improved status bar styling (#1221) - Added horizontal scrollbar to editor (#1228) - Add theme for scrollbars (#1233)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/690
Summary
Issue related:
block-sizetomin-block-sizeto allow height to growFixing failing tests:
min-block-sizethis was causing cypress visiblity test to fail.display: noneto properly remove the elementDemo